Builder wget-solaris10-sparc Build #558
Results:
Failed shell shell_1 shell_2 shell_3
SourceStamp:
| Project | wget |
| Repository | https://gitlab.com/gnuwget/wget.git |
| Branch | master |
| Revision | 81736a395fdb86d0496b9f5603f9232c72338688 |
| Got Revision | 81736a395fdb86d0496b9f5603f9232c72338688 |
| Changes | 2 changes |
BuildSlave:
unstable10sReason:
The SingleBranchScheduler scheduler named 'schedule-wget-solaris10-sparc' triggered this build
Steps and Logfiles:
Build Properties:
| Name | Value | Source |
|---|---|---|
| branch | master | Build |
| builddir | /export/home/buildbot-unstable10s/slave/wget-solaris10-sparc | slave |
| buildername | wget-solaris10-sparc | Builder |
| buildnumber | 558 | Build |
| codebase | Build | |
| got_revision | 81736a395fdb86d0496b9f5603f9232c72338688 | Git |
| project | wget | Build |
| repository | https://gitlab.com/gnuwget/wget.git | Build |
| revision | 81736a395fdb86d0496b9f5603f9232c72338688 | Build |
| scheduler | schedule-wget-solaris10-sparc | Scheduler |
| slavename | unstable10s | BuildSlave |
| workdir | /export/home/buildbot-unstable10s/slave/wget-solaris10-sparc | slave (deprecated) |
Forced Build Properties:
| Name | Label | Value |
|---|
Responsible Users:
- Samuel Dainardsdainard@amazon.com
Timing:
| Start | Wed Jun 17 14:29:31 2026 |
| End | Wed Jun 17 14:30:42 2026 |
| Elapsed | 1 mins, 10 secs |
All Changes:
:
Change #271463
Category wget Changed by Samuel Dainard <sdainard@amazon.com> Changed at Wed 17 Jun 2026 14:15:46 Repository https://gitlab.com/gnuwget/wget.git Project wget Branch master Revision 1be27f6c30aa6c43e09968986965aaab77ba46fa Comments
Fix undefined behavior in is_valid_port is_valid_port() uses atoi() which has undefined behavior on integer overflow (e.g. input "99999999999"). Since this function is part of the CVE-2024-10524 fix and processes untrusted input, replace atoi() with strtoul() which sets errno to ERANGE on overflow. Also add a leading digit check via c_isdigit() to reject inputs that don't start with a digit, and remove the separate strspn() call since strtoul()'s end pointer provides the same information. * src/url.c (is_valid_port): Replace atoi with strtoul, add digit check, validate via end pointer instead of strspn. Copyright-paperwork-exempt: Yes
Changed files
- src/url.c
Change #271464
Category wget Changed by Samuel Dainard <sdainard@amazon.com> Changed at Wed 17 Jun 2026 14:16:21 Repository https://gitlab.com/gnuwget/wget.git Project wget Branch master Revision 81736a395fdb86d0496b9f5603f9232c72338688 Comments
Limit colon search to authority in maybe_prepend_scheme maybe_prepend_scheme() uses strchr(url, ':') which finds the first colon anywhere in the URL string, including in the path component. A URL like "www.example.com/path:name" will find the colon in "path:name", fail is_valid_port("name"), and return NULL -- incorrectly refusing to prepend "http://". Limit the colon search to the authority portion by also finding the first slash and ignoring any colon that appears after it. * src/url.c (maybe_prepend_scheme): Add slash check to ignore colons in the path component. Copyright-paperwork-exempt: YesChanged files
- src/url.c